Define a bounded capacity for the internal SNI to SslContext cache.#6102
Merged
Conversation
Motivation: The SNI to SslContext cache does not define a max size, this cache can be filled by TLS client when server SNI is enabled. Client can trigger to load multiple times the same SslContext for a given certificate with arbitrary SNI names when the server uses certificates with a wildcard CN. Changes: Introduce a max size based on LRU policy for the cache with a reasonnable default.
vietj
force-pushed
the
unbounded-sni-cache-growth-5.0
branch
from
01991e3 to
cde2517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The SNI to
SslContextcache does not define a max size, this cache can be filled by TLS client when server SNI is enabled.Client can trigger to load multiple times the same
SslContextfor a given certificate with arbitrary SNI names when the server uses certificates with a wildcard CN.Changes:
Introduce a max size based on LRU policy for the cache with a reasonnable default.